Implement a check of the druid formName instead of ID of the form#865
Open
racha wants to merge 2 commits intoElvUI-WotLK:masterfrom
Open
Implement a check of the druid formName instead of ID of the form#865racha wants to merge 2 commits intoElvUI-WotLK:masterfrom
racha wants to merge 2 commits intoElvUI-WotLK:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes a server can return ID of 2 instead of ID of 3 for a "Cat Form", Not sure why, maybe if you train cat form before Aquatic Form ? So in order to make sure this is bulletproof there should be a check for the formName instead of an ID