refactor: rename fs-explorer to Opensidian#1518
Merged
Conversation
Rebrand the dev filesystem UI into OpenSidian—the starting point for an Obsidian-like note-taking app within the Epicenter monorepo. - git mv apps/fs-explorer → apps/opensidian - Update package name, workspace ID, HTML title, README - Regenerate lockfile with new package references
…tory throw When a withExtension factory threw, destroyLifo was called fire-and-forget. Because destroyLifo uses await between iterations, only the first cleanup's synchronous portion ran before the re-throw yielded to the microtask queue— remaining cleanups were stranded and never started before error propagation. Add startDestroyLifo: a sync variant that invokes every cleanup in LIFO order without awaiting between them. Async portions settle in the background with rejections observed via Promise.resolve().catch(). This is the strongest rollback guarantee a sync builder can provide—all cleanups are started before the error escapes. The original destroyLifo is preserved for the normal destroy() path where full sequential await is appropriate.
braden-w
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebrands
apps/fs-exploreras Opensidian—the starting point for an open-source, local-first Obsidian-like note-taking app within the Epicenter monorepo. The app already has the bones of a file manager (tree view, content editor, create/rename/delete) built on Yjs CRDTs; this rename sets the direction for gradual evolution.The old name described what it was (a dev tool for testing
@epicenter/filesystem). The new name describes what it's becoming. No real users exist on the current IndexedDB data, so the workspace ID change is a clean break.The README was rewritten from "dev tool for inspecting filesystem operations" to a proper app description. Historical specs that reference
fs-explorerare left untouched—they're accurate records of past work and the spec explicitly scopes them out.Straggler sweep
After the rename, five parallel grep agents searched the entire repo for any remaining
fs-explorerreferences across config files, source code, CI workflows, markdown docs, and lockfiles. Results:specs/orEXECUTE_UNIFY_EXTENSION_LIFECYCLE.md(historical documents)fs_explorer,fsexplorer,Filesystem Explorer)bun.lockregenerated cleanly viabun installNo stragglers. The rename is complete.