refactor: mutation-default approval, tab-manager actions, DO tracking, CLA#1531
Merged
refactor: mutation-default approval, tab-manager actions, DO tracking, CLA#1531
Conversation
…yDomain as workspace actions - Extract pure helpers (normalizeUrl, findDuplicateGroups, groupTabsByDomain) to tab-helpers.ts - Add tabs.findDuplicates query, tabs.dedup destructive mutation, tabs.groupByDomain mutation - Trim QuickActions from 5 to 2 (dedup + groupByDomain), remove sort/saveAll/closeByDomain
… ActionMeta All mutations will require approval by default. The per-action destructive flag is no longer needed.
…e flag All mutations now get needsApproval: true. Queries omit it entirely. The toolTrust table handles approval fatigue via [Always Allow].
…ntics All mutations now get needsApproval, not just destructive ones. Queries still omit it entirely.
The action type (query/mutation) now determines approval semantics. MCP consumers can infer approval from the existing `type` field.
The destructive field no longer exists on ActionDescriptor.
tabs.close now gets approval because it's a mutation, not because of an explicit destructive flag.
…JSDoc Updates tool-trust, system-prompt, and chat-state comments to reflect the new mutation-default approval model.
Missed in Phase 6 — added after the spec was written. Now removed to match the mutation-default approval model.
Users can now view and revoke "Always Allow" tool decisions from a gear icon in the AI chat drawer header. TrustSettings.svelte shows trusted tools with Switch toggles and a "Revoke All" option. Spec: specs/20260314T061500-tool-trust-revocation-settings.md
Check off all implementation items and success criteria, add review section noting the extra tabs.dedup call site discovered during implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the per-action
destructiveflag and makes all mutations require approval by default. ThetoolTrusttable (CRDT-synced [Always Allow]) already solves approval fatigue—this change flips the default so developer omission can't silently bypass approval.The old system required
destructive: trueon each action. Out of 8 tab-manager mutations, onlytabs.closehad it—the other 7 auto-executed with zero friction. That's not a deliberate choice; it's an omission.The trust escalation flow is unchanged—users click [Always Allow] once per mutation and the preference syncs across devices via CRDT.
Other changes in this branch
Tab manager: Extract shared tab helpers (
findDuplicateGroups,groupByDomain) from quick-actions intotab-helpers.tsand exposetabs.dedupandtabs.groupByDomainas workspace actions. Add trust revocation settings popover in the AI drawer so users can manage their [Always Allow] grants.API: Track Durable Object instances with storage size on every access (
durable_object_instancetable + migration). AdddeleteStorageRPC method toBaseSyncRoom. SimplifyafterResponsequeue drain API.Infrastructure: Add CLA for commercial licensing. Redesign GitHub issue templates and PR template for prose-first contributions. Add CODEOWNERS.
Docs: Writing voice financial language guideline. Git skill compression (remove redundant sections, collapse ASCII art catalog). Piggybacking storage tracking article. Multiple specs marked as implemented.