Add lens IDs for Sigma 150+TC, 100-400/+TC, Tamron 85#9294
Open
byteit101 wants to merge 1 commit intoExiv2:mainfrom
Open
Add lens IDs for Sigma 150+TC, 100-400/+TC, Tamron 85#9294byteit101 wants to merge 1 commit intoExiv2:mainfrom
byteit101 wants to merge 1 commit intoExiv2:mainfrom
Conversation
kmilos
requested changes
Apr 22, 2026
Collaborator
There are existing entries of "+ TC-14E" but that might be Nikkor specific part... I've noticed Exiftool used "+ 1.4x TC" in one instance, so could align to that? (Exiftool also has "TC-1.4x" for some more recent Nikkor Z lenses, but that could be specific as well...)
Where does the Nikon entry come from then? Need to address clang-format otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Lens IDs for:
I wasn't entirely sure of the format for the Nikon Teleconverter, so I copied the Canon style. The canon ones have sample images uploaded to lensfun/lensfun#2773