pretty.Sprint is CPU intensive, print only once#13
Open
diwu1989 wants to merge 1 commit intoExpansiveWorlds:masterfrom
Open
pretty.Sprint is CPU intensive, print only once#13diwu1989 wants to merge 1 commit intoExpansiveWorlds:masterfrom
diwu1989 wants to merge 1 commit intoExpansiveWorlds:masterfrom
Conversation
|
Hey there, this repo is not actively maintained, would you be willing to submit this PR to my fork ? https://github.com/luna-duclos/instrumentedsql |
slagiewka
added a commit
to slagiewka/instrumentedsql
that referenced
this pull request
Sep 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
pretty.Sprintis pretty heavy, we should only be doing it once instead of twice.The args don't mutate during the query, so we can generate the args string once and use it for tracing and for logging.