WIP: refactor attempt of BehaviourEnabledObserver#419
Open
fight4dream wants to merge 1 commit intoExtendRealityLtd:masterfrom
Open
WIP: refactor attempt of BehaviourEnabledObserver#419fight4dream wants to merge 1 commit intoExtendRealityLtd:masterfrom
fight4dream wants to merge 1 commit intoExtendRealityLtd:masterfrom
Conversation
bddckr
changed the title
Contributor
|
You can just open your PR as a draft next time. I don't believe GitHub allows changing a PR back to the draft state, so I instead added the No hacky commits needed here, instead you can ensure the commits are clean for reviewers to look at. |
Contributor
Author
|
Thanks Chris. How could I make a draft PR? Is there an option to check when I am about to make one? |
Contributor
|
Yup! Currently no way provided by GitHub to change a PR to draft once created, though. More info: https://github.blog/2019-02-14-introducing-draft-pull-requests/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT accept the PR.
Only for a reivew and discussion on the attempt to refractor of BehaviourEnabledObserver #321
the CoroutineMomentProcessor involved is related to #274