LLVM: lower fixed-array params as byval aggregates#57
Merged
Conversation
itsfuad
force-pushed
the
llvm-array-param-lowering-fix
branch
from
e84228b to
698f10b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix LLVM lowering for fixed-array function parameters (for example
[2]i32) so they are emitted as aggregatebyvalparams instead of falling through scalar base-type lowering.Fixes #56
What changed
llvmABITypeNamenow classifiesArrayTypelike tuple aggregates and returns sized aggregate ABI type ([N x i8]).llvmBaseTypenow unwrapsApproxType(~T) before scalar base-type resolution.TestLowerProgramFunctionArrayParamUsesByValAggregateto ensure array param lowering stays stable.Why
Previously, array params could hit:
unsupported llvm base type [N]Tthrough scalar fallback paths during function lowering.
Validation
go test ./internal/backend/llvm -count=1