Skip to content

fix(plex): Also read MBIDs from guid field #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owendaprile wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(plex): Also read MBIDs from guid field #473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 32 additions & 10 deletions src/backend/sources/PlexApiSource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ const shortDeviceId = truncateStringToLength(10, '');

export const LOCAL_USER = 'PLEX_LOCAL_USER';

const MBID_PREFIX = "mbid://";

const THUMB_REGEX = new RegExp(/\/library\/metadata\/(?<ratingkey>\d+)\/thumb\/\d+/)

export default class PlexApiSource extends MemoryPositionalSource {
Expand Down Expand Up @@ -533,8 +535,8 @@ ${JSON.stringify(obj)}`);
getNewPlayer = (logger: Logger, id: PlayPlatformId, opts: PlayerStateOptions) => new PlexPlayerState(logger, id, opts);

getMusicBrainzId = async (ratingKey: string | undefined): Promise<string | undefined> => {
if (!ratingKey) {
return null;
if (ratingKey === undefined) {
return undefined;
}

const cachedMbId = await this.mbIdCache.get(ratingKey);
Expand Down Expand Up @@ -565,24 +567,44 @@ ${JSON.stringify(obj)}`);
);

const result = await request.json();

let mbid: string | null = null;

// There shouldn't be multiple metadata or GUID objects, but we return
// the first MBID to be safe.
for (const metadata of result.MediaContainer.Metadata ?? []) {
for (const guid of metadata.Guid ?? []) {
if (typeof guid.id === "string" && guid.id.startsWith("mbid://")) {
const mbid = guid.id.replace("mbid://", "");

await this.mbIdCache.set(ratingKey, mbid);
return mbid;
metadataLoop: for (const metadata of result?.MediaContainer?.Metadata ?? []) {
this.logger.trace(`Guid: '${metadata.Guid?.map(g => g.id)?.join(", ")}', guid: '${metadata.guid}'`)

if (Array.isArray(metadata.Guid)) {
for (const guid of metadata.Guid) {
if (typeof guid.id === "string" && guid.id.startsWith(MBID_PREFIX)) {
mbid = guid.id.replace(MBID_PREFIX, "");
break metadataLoop;
}
}
}

// Some matched items store the MBID in the `MediaContainer.Metadata.guid` field,
// so we check that as a fallback if there are no objects in the `Guid` field.
if (typeof metadata.guid === "string" && metadata.guid.startsWith(MBID_PREFIX)) {
mbid = metadata.guid.replace(MBID_PREFIX, "");
break metadataLoop;
}
}

this.logger.trace(`Extracted MBID: '${mbid}'`);

await this.mbIdCache.set(ratingKey, mbid);

if (mbid === null) {
return undefined
}

return mbid;
} catch (e) {
this.logger.warn(new Error(`Failed to get MusicBrainz IDs from Plex for item ${ratingKey}`, {cause: e}));
}

this.mbIdCache.set(ratingKey, null);
return undefined;
}
}
Expand Down