Conversation
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Fix inability to drag grid videos to different rows. Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Signed-off-by: Android789515 <derflug@mailfence.com>
Also only save once on drag end
|
Thank you for picking these changes up and continuing the work on them. One thing I noticed in my testing is that it is not possible to drag a video back to the location it came from aka cancelling the move. |
| @mouseenter="grabBarHovered = true" | ||
| @mouseleave="grabBarHovered = false" |
There was a problem hiding this comment.
Because you can only drag after you have moved a mouse pointer over the video number it makes dragging on a touch screen impossible :(
You can test it on your phone using the steps mentioned here: #8621 (comment)
There was a problem hiding this comment.
Update: Did a fix, please check
src/renderer/components/FtListVideoNumbered/FtListVideoNumbered.vue
Outdated
Show resolved
Hide resolved
src/renderer/components/FtListLazyWrapper/FtListLazyWrapper.vue
Outdated
Show resolved
Hide resolved
|
To ensure list view is not broken, ensure to test the list view in search results (video playlist channel hashtag) to ensure nothing broken |
|
Question: If you have a playlist on YouTube and switch the sorting to Manual (its called Custom on our side) it will replace the index numbers and with the grab bar. Do we want todo the same or keep the current approach? |
…humbnail and info
Sure lets do that. |
|
@efb4f5ff-1298-471a-8973-3d47447115dc Updated |


Pull Request Type
Related issue
Continue of #8621
Closes #4872
Description
Adds drag and drop ordering when custom sort is enabled for playlist videos both in list and grid view.
Grab bar on hover (list view only)
List drag and drop
Grid drag and drop
Testing
Testing instructions
To ensure list view is not broken, ensure to test the list view in search results (video playlist channel hashtag) to ensure nothing broken
Desktop
Additional context
https://github.com/maranran/eslint-plugin-vue-a11y/blob/master/docs/rules/mouse-events-have-key-events.md ignored for mouseenter/mouseleave let me know if it's not desired