Add classes to body for dark and light mode targeting by aybanda · Pull Request #78 · FriendsOfFlarum/nightmode

aybanda · 2024-12-30T10:04:33Z

Fixes #77

Changes proposed in this pull request:

Added fof-DarkMode and fof-LightMode classes to the <body> tag when switching themes in the switchTheme.ts file.
This change allows for better targeting of styles specific to dark and light modes, improving readability and user experience.

Reviewers should focus on:

The logic for adding and removing classes from the <body> tag.
Ensuring that the changes do not affect existing functionality.
Feedback on whether the class names align with the project's naming conventions.

Confirmed

dsevillamartin · 2024-12-31T18:55:50Z

Haven't tested this, but it'd probably need to be set in setTheme instead.

However, I think it's best not to bother as

this is already possible to do with LESS variables (https://discuss.flarum.org/d/21492-friendsofflarum-night-mode/405)
auto night mode will be built in for Flarum 2.0 once that is released

Since it is already possible to target the styles, I don't think this is necessary.

Add classes to body for dark and light mode targeting

2b992ac

Provide feedback