add configurable OAuth user field mappings#44
Open
Kreal321 wants to merge 1 commit intoFriendsOfFlarum:masterfrom
Open
add configurable OAuth user field mappings#44Kreal321 wants to merge 1 commit intoFriendsOfFlarum:masterfrom
Kreal321 wants to merge 1 commit intoFriendsOfFlarum:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43
Different OAuth providers use different field names in their userinfo endpoints. For example, Clerk uses user_id instead of id, which results in a null value for the required field. The solution is to add these configurations as new input fields in the admin page.
Changes proposed in this pull request:
Reviewers should focus on:
None. It’s a fairly simple change. I used the existing ResourceOwner::setFields design, which had been created earlier for extensions but wasn’t in use, minimizing any impact on the logic. Only three additional fields were added to the admin settings.
Screenshot
Confirmed
composer test).Required changes:
None