fix: discussion split when user deleted#72
Open
grimur82 wants to merge 2 commits into
Open
Conversation
grimur82
changed the title
grimur82
changed the title
grimur82
changed the title
DavideIadeluca
requested changes
Apr 16, 2026
Member
DavideIadeluca
left a comment
DavideIadeluca
left a comment
There was a problem hiding this comment.
Can you please fill out the PR description? Based on the PR title I have no idea what this is about. Specifically, share steps to reproduce the issue and demonstrate how that PR fixes this issue. Thanks
Member
There was a problem hiding this comment.
Just so that we have a consistent setup across the board, could you please use the same composer.json setup for tests like in other extensions? Iirc the Flarum CLI adds it as desired
Member
There was a problem hiding this comment.
Please also use the CLI here so that we have this consistent
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
Confirmed
composer test).Required changes: