fix: Accelerate the HPCReact unit test - #4131
Merged
victorapm merged 3 commits intoAug 30, 2026
Merged
Conversation
* Add kernelSpec.json * Add relative permeability template * Add hysteresis check * Correct embedded documentation typos in kernelSpecs.json (#4086) * Fix typos in kernelSpecs embedded docs
* Add 1D cooling tutorial to doc * wordsmithing the example rest * update wellbore thermal tutorials --------- Co-authored-by: Jian Huang <53012159+jhuang2601@users.noreply.github.com> Co-authored-by: Herve Gross <40979822+herve-gross@users.noreply.github.com>
frankfeifan
requested review from
OmarDuran,
dkachuma,
jhuang2601,
joshua-white and
rrsettgast
as code owners
August 30, 2026 05:47
frankfeifan
added
flag: ready for review
flag: requires updated submodule(s)
flag: no rebaseline
Contributor
Author
|
@victorapm , could you check if the unit test takes reasonable amount of time now? |
Contributor
|
Thanks, Frank! I'm merging this into my other development branch related to unit tests |
victorapm
changed the base branch from
develop
to
fix/paludettomag1/cuda-tests
August 30, 2026 14:30
victorapm
merged commit Aug 30, 2026
6964ebd
into
fix/paludettomag1/cuda-tests
19 of 22 checks passed
Contributor
Author
Sounds great. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to accelerate the HPCReact unit test
testKineticReactions.computeReactionRatesTest_carbonateSystemAllKineticby reducing the number of timestep, so it can run faster on CUDA.This PR depends on GEOS-DEV/HPCReact#24 in HPCReact.