GT-127 Outdated links to be configurable #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is similar too and will conflict with #412 |
rowan04
changed the title
rowan04
changed the title
Member
|
I want to make the necassary config change, in a sandbox, at the same time before merging this. |
…and Service Groups - changes to local_info.xml and Config.php to allow configurable links
…able links - changes to controllers to add configurable link to params array - changes to views to use the params array
Member
|
rebasing to update |
gregcorbett
force-pushed
the
433-outdated-links-to-be-configurable
branch
2 times, most recently
from
c73eba7 to
247ef63
Compare
gregcorbett
dismissed
their stale review
I've added two commits on top of this, so I'd appreciate someone else reviewing.
Member
tofu-rocketry
left a comment
tofu-rocketry
left a comment
There was a problem hiding this comment.
Could you clarify the purpose of 357fa82?
- new configurable elements have been added to local_info.xml to allow documentation links to be configurable (and not hardcoded). - These new elements need corresponding schema definitions to ensure an updated local_info.xml continues to pass the validation check.
gregcorbett
force-pushed
the
433-outdated-links-to-be-configurable
branch
from
247ef63 to
8cde4cf
Compare
Member
Member
|
Thanks. Your commits look ok now. I can green tick this if you like, but on the understanding I've not got to grips with the rest of the PR. |
Member
|
Sound good to me 👍 |
tofu-rocketry
approved these changes
Oct 2, 2025
Member
tofu-rocketry
left a comment
tofu-rocketry
left a comment
There was a problem hiding this comment.
Limited approval for @gregcorbett 's additional commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #433
Adds configurable options for projects, ngis and service groups.