Paint Misc Prereqs - #7052
Open
danieldresser-ie wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we prepare for the release of 1.7, I'm looking through the paint branch for anything that might require a compatibility break.
I'm not seeing anything that actually does require a compatibility break, but here are two commits that feel a little bit intrusive into how things currently work.
They aren't urgent ... unless you don't like how they work, and can think of a better approach that would be an ABI break.
One reworks how enter/leave signals are handled with overlays ( you now get a leave event when the cursor is over the overlay instead of the ViewportGadget ). The other is a special OpenGL render override "gl:hideSelected", which allows a tool to implement its own rendering of the selected objects.