Remove obsolete AC_GECODE_TIMER M4 macro from configure.ac.in - #197
Closed
kaol wants to merge 1 commit into
Closed
Conversation
In bc31c31 Gecode's timer handling was unified to std::chrono::steady_clock. This removed the need for checking at build time for which timer to use and AC_GECODE_TIMER M4 macro was removed that tested for them but the configure.ac.in still had the call, breaking autotools build.
Member
|
Thanks for the contribution, and sorry this stayed open for so long. I reviewed this against the current I’m closing this as superseded. Thank you for the patch; it was still useful context while checking the current state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In bc31c31 Gecode's timer handling was unified to std::chrono::steady_clock. This removed the need for checking at build time for which timer to use and AC_GECODE_TIMER M4 macro was removed that tested for them but the configure.ac.in still had the call, breaking autotools build.