Open
Conversation
# Conflicts: # proxy/src/main/java/com/velocitypowered/proxy/redis/RedisManagerImpl.java # proxy/src/main/java/com/velocitypowered/proxy/redis/multiproxy/MultiProxyHandler.java
# Conflicts: # proxy/src/main/java/com/velocitypowered/proxy/VelocityServer.java
Commit didn't pull upstream yet.
…nagement & use unique id's instead of Player object in player related queue-operations
# Conflicts: # proxy/src/main/java/com/velocitypowered/proxy/connection/client/ConnectedPlayer.java # proxy/src/main/java/com/velocitypowered/proxy/redis/multiproxy/MultiProxyHandler.java
… and ensures thread safety
Collaborator
|
The fixed Microslop copilot's suggestions have been implemented in https://github.com/GemstoneGG/Velocity-CTD/tree/xcd-merge-queue-reimplementation, this will get merged into this branch/PR soon (once the queue reimplementation is mature enough). Microslop copilot suggested 1 actual good fix for an edge case which we would never hit, one real typo in a javadoc comment, and suggested to add |
Collaborator
Merged. |
…ver switch, and by not calling removePlayerEntirely() when connecting to the first server after joining the proxy
This was referenced Mar 9, 2026
- Ghost players not tracked by proxy but still being connected when TransitionSessionHandler#disconnected got called during a transfer. - Properly fix handling an error state during "Reconfiguring..." in ConfigSessionHandler#disconnected by completing the future NON-exceptionally with an error result. Upstream's solution is (still) to throw an IOException here, causing in error spam and the wrong code being executed in handlers of the futures. Our solution used to be removing the player state (and hoping the connection would drop) but the connection could stay alive, introducing the ghost player. This new fix is to just handle it like an INTERNAL_SERVER_CONNECTION_ERROR, meaning the right choice will be made in the handler of the futures (either disconnect the player or abort the transfer). See PaperMC#1251
…ation module (reduces unnecessary & excessive class casts)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The long-awaited rewrite of CTD that stabilizes and improves the entirety of CTD.