Skip to content

Conversation

@gpunto
Copy link
Contributor

@gpunto gpunto commented Dec 17, 2025

Goal

AND-781: Unify CI Across SDKs

We now have a CI workflow with common steps, so we're using that

Implementation

Use shared CI workflow

Testing

The expected pipeline steps should be run

Checklist

  • Issue linked (if any)
  • Tests/docs updated
  • I have signed the Stream CLA (required for external contributors)

Summary by CodeRabbit

  • Chores
    • Switched Android CI to a consolidated external workflow, replacing multiple individual CI jobs with a single workflow call to simplify and streamline continuous integration.
    • Disabled an optional API-check step to reduce unnecessary CI noise and speed up runs.

✏️ Tip: You can customize this high-level summary in your review settings.

@gpunto gpunto added the pr:ci CI changes label Dec 17, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 17, 2025

Walkthrough

Replaced the repository's multi-job Android GitHub Actions workflow with a single reusable workflow call to GetStream/stream-build-conventions-android, removing in-repo job definitions and directly inheriting secrets and configuration (api-check: false).

Changes

Cohort / File(s) Summary
CI Workflow Consolidation
​.github/workflows/android.yml
Removed in-repo multi-job Android CI (build, spotless, lint, unitTest, Sonar steps) and replaced it with a reusable workflow call to GetStream/stream-build-conventions-android/.github/workflows/[email protected]; uses secrets: inherit and with: { api-check: false }.

Sequence Diagram(s)

(omitted — change is CI consolidation, no runtime multi-component control flow requiring a sequence diagram)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • aleksandar-apostolov
  • VelikovPetar

Poem

🐰 Hopped through YAML, tidy and spry,
Jobs now wander where shared workflows lie,
Secrets inherited, checks set to small,
One tidy call replaces them all!

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: switching to a shared Android CI workflow from common workflows.
Description check ✅ Passed The description covers all required template sections (Goal, Implementation, Testing, Checklist) with relevant details and issue linkage.
Linked Issues check ✅ Passed The PR fully addresses AND-781's objectives by applying a shared CI workflow to the Feeds SDK repository.
Out of Scope Changes check ✅ Passed All changes are scoped to unified CI implementation with no unrelated modifications to codebase or configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch and-781/unify-android-ci

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d4f95d1 and 797630c.

📒 Files selected for processing (1)
  • .github/workflows/android.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: compare-sdk-sizes / Compare SDK sizes
  • GitHub Check: android-ci / Build
  • GitHub Check: android-ci / Run static checks
  • GitHub Check: android-ci / Run unit tests
🔇 Additional comments (1)
.github/workflows/android.yml (1)

20-24: Confirm v0.6.1 is the latest version and verify api-check setting.

v0.6.1 is the latest available version of the shared workflow, so the migration is using the current release.

However, since stream-feeds-android is a library/SDK, please confirm that api-check: false is intentional. API compatibility checking is typically important for libraries—if it should be enabled, change this to true.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

@gpunto gpunto force-pushed the and-781/unify-android-ci branch from 6d954f8 to e10ead4 Compare December 17, 2025 13:31
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-feeds-android-client 2.43 MB 2.43 MB 0.00 MB 🟢

@gpunto gpunto force-pushed the and-781/unify-android-ci branch 5 times, most recently from 81055e4 to d4f95d1 Compare December 23, 2025 16:18
@gpunto gpunto marked this pull request as ready for review December 23, 2025 16:34
@gpunto gpunto force-pushed the and-781/unify-android-ci branch from 78fb166 to 797630c Compare December 24, 2025 12:37
@sonarqubecloud
Copy link

@VelikovPetar VelikovPetar merged commit 9ecda57 into develop Dec 24, 2025
8 checks passed
@VelikovPetar VelikovPetar deleted the and-781/unify-android-ci branch December 24, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ci CI changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants