Skip to content

Support for SnakeYaml 2.0+ (Velocity 3.5.0 and later)#654

Merged
Tim203 merged 1 commit intoGeyserMC:masterfrom
mfnalex:feat/support-velocity-3.5.0
Mar 19, 2026
Merged

Support for SnakeYaml 2.0+ (Velocity 3.5.0 and later)#654
Tim203 merged 1 commit intoGeyserMC:masterfrom
mfnalex:feat/support-velocity-3.5.0

Conversation

@mfnalex
Copy link
Copy Markdown
Contributor

@mfnalex mfnalex commented Mar 6, 2026

Fixes #649

Since SnakeYaml 2.0, the CustomClassLoaderConstructor requires a LoaderOptions object as second parameter. This PR simply catches the NoSuchMethodError and then tries again with the new Constructor through reflection.

Works fine for me on Velocity 3.5.0-SNAPSHOT (git-e0db2566-b577)

@WouterGritter
Copy link
Copy Markdown

I would really like to see this merged, as floodgate is currently still broken on the latest Velocity(-CTD).

@Tim203
Copy link
Copy Markdown
Member

Tim203 commented Mar 19, 2026

Thanks for the reminder. I think that this PR looks good.
This will at least make Floodgate work again. I really don't have time to make the changes needed for that other PR that also makes local linking work for those new Velocity versions.

@Tim203 Tim203 merged commit 869338c into GeyserMC:master Mar 19, 2026
1 check passed
@mfnalex
Copy link
Copy Markdown
Contributor Author

mfnalex commented Mar 20, 2026

Thanks for merging. Local linking does work fine for us using this version, btw (using MySQL backend, not SQLite though as also mentioned in the other PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Velocity 3.5.0: Suddenly account linking no longer works & "Linking is not enabled on this server"

3 participants