Skip to content

Fix Java 25 Build#6292

Merged
Kas-tle merged 2 commits intoGeyserMC:masterfrom
Kas-tle:fix/java-25-nonsense
Apr 8, 2026
Merged

Fix Java 25 Build#6292
Kas-tle merged 2 commits intoGeyserMC:masterfrom
Kas-tle:fix/java-25-nonsense

Conversation

@Kas-tle
Copy link
Copy Markdown
Member

@Kas-tle Kas-tle commented Apr 8, 2026

Jitpack parts can be reverted when Architectury is dropped.

Copilot AI review requested due to automatic review settings April 8, 2026 15:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Gradle build configuration to keep builds working on newer Java runtimes (e.g., Java 25) by pinning toolchain usage to Java 21 and adjusting plugin resolution to a forked Architectury plugin.

Changes:

  • Add Foojay toolchain resolver convention plugin to enable auto-downloading toolchains.
  • Enforce Java 21 toolchains for build-logic and modded convention builds.
  • Switch Architectury plugin resolution to a fork/commit and add JitPack as a repository source.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
settings.gradle.kts Adds JitPack to pluginManagement and applies the Foojay toolchain resolver convention plugin.
gradle/libs.versions.toml Points architectury-plugin to a fork/commit-based coordinate.
build-logic/src/main/kotlin/geyser.modded-conventions.gradle.kts Forces Java 21 toolchain for modded convention projects.
build-logic/settings.gradle.kts Applies the Foojay toolchain resolver convention plugin for the included build.
build-logic/build.gradle.kts Forces Java 21 toolchain for build-logic and adds JitPack to repositories.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Kas-tle Kas-tle merged commit 586fd44 into GeyserMC:master Apr 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants