Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Gradle build configuration to keep builds working on newer Java runtimes (e.g., Java 25) by pinning toolchain usage to Java 21 and adjusting plugin resolution to a forked Architectury plugin.
Changes:
- Add Foojay toolchain resolver convention plugin to enable auto-downloading toolchains.
- Enforce Java 21 toolchains for build-logic and modded convention builds.
- Switch Architectury plugin resolution to a fork/commit and add JitPack as a repository source.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Adds JitPack to pluginManagement and applies the Foojay toolchain resolver convention plugin. |
| gradle/libs.versions.toml | Points architectury-plugin to a fork/commit-based coordinate. |
| build-logic/src/main/kotlin/geyser.modded-conventions.gradle.kts | Forces Java 21 toolchain for modded convention projects. |
| build-logic/settings.gradle.kts | Applies the Foojay toolchain resolver convention plugin for the included build. |
| build-logic/build.gradle.kts | Forces Java 21 toolchain for build-logic and adds JitPack to repositories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
onebeastchris
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jitpack parts can be reverted when Architectury is dropped.