Merged
Conversation
Contributor
|
do you have screenshot of after? |
Contributor
Author
gnanam1990
requested changes
Apr 7, 2026
Collaborator
gnanam1990
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up and for adding the before/after screenshots.
I think this is very close, but I noticed one place where the stale example still remains:
src/components/agents/generateAgent.ts:71
This PR updatessrc/tools/AgentTool/prompt.tsto remove the outdatedgreeting-responderexample, but the same example is still present in the agent-generation prompt template. That means we still have one user-facing path that references a built-in agent that does not exist.
Could you please update generateAgent.ts in the same PR so the examples stay consistent across both prompt surfaces?
Once that is cleaned up as well, this looks good to me.
kevincodex1
reviewed
Apr 7, 2026
| Context: User is creating an agent to respond to the word "hello" with a friendly jok. | ||
| user: "Hello" | ||
| assistant: "I'm going to use the ${AGENT_TOOL_NAME} tool to launch the greeting-responder agent to respond with a friendly joke" | ||
| Context: User is creating an agent for Claude Code product questions. |
Contributor
There was a problem hiding this comment.
can we rename this to Open Claude ? lets replace Claude Code with Open Claude
Vasanthdev2004
approved these changes
Apr 7, 2026
Collaborator
Vasanthdev2004
left a comment
There was a problem hiding this comment.
No blocking findings on the current head cae62409085b30c3c50eedda42e32c642de5bccb relative to current origin/main.
What I verified:
- the previous blocker is fixed:
src/components/agents/generateAgent.tsno longer references the nonexistentgreeting-responderagent - the replacement examples in
src/tools/AgentTool/prompt.tspoint at real built-in agents (claude-code-guideandstatusline-setup) - repo-wide search no longer finds
greeting-responder/friendly jokereferences bun run buildbun run smoke
Non-blocking note:
- this is a prompt-only behavior change and I did not find automated coverage around these example strings, so there is still some model-behavior risk (especially around proactive agent invocation), but I did not find a concrete code-level regression in the current diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Remove example agent description that doesn't exist in available agents.
Before:

Testing
bun run buildbun run smokebun run test