Skip to content

Fix greeting responder#438

Merged
kevincodex1 merged 4 commits intoGitlawb:mainfrom
lunamonke:fix-greeting_responder
Apr 7, 2026
Merged

Fix greeting responder#438
kevincodex1 merged 4 commits intoGitlawb:mainfrom
lunamonke:fix-greeting_responder

Conversation

@lunamonke
Copy link
Copy Markdown
Contributor

Summary

Remove example agent description that doesn't exist in available agents.

Before:
image

Testing

  • bun run build
  • bun run smoke
  • bun run test

@kevincodex1
Copy link
Copy Markdown
Contributor

do you have screenshot of after?

@lunamonke
Copy link
Copy Markdown
Contributor Author

@kevincodex1

image

Copy link
Copy Markdown
Collaborator

@gnanam1990 gnanam1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up and for adding the before/after screenshots.

I think this is very close, but I noticed one place where the stale example still remains:

  1. src/components/agents/generateAgent.ts:71
    This PR updates src/tools/AgentTool/prompt.ts to remove the outdated greeting-responder example, but the same example is still present in the agent-generation prompt template. That means we still have one user-facing path that references a built-in agent that does not exist.

Could you please update generateAgent.ts in the same PR so the examples stay consistent across both prompt surfaces?

Once that is cleaned up as well, this looks good to me.

Context: User is creating an agent to respond to the word "hello" with a friendly jok.
user: "Hello"
assistant: "I'm going to use the ${AGENT_TOOL_NAME} tool to launch the greeting-responder agent to respond with a friendly joke"
Context: User is creating an agent for Claude Code product questions.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename this to Open Claude ? lets replace Claude Code with Open Claude

Copy link
Copy Markdown
Collaborator

@Vasanthdev2004 Vasanthdev2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking findings on the current head cae62409085b30c3c50eedda42e32c642de5bccb relative to current origin/main.

What I verified:

  • the previous blocker is fixed: src/components/agents/generateAgent.ts no longer references the nonexistent greeting-responder agent
  • the replacement examples in src/tools/AgentTool/prompt.ts point at real built-in agents (claude-code-guide and statusline-setup)
  • repo-wide search no longer finds greeting-responder / friendly joke references
  • bun run build
  • bun run smoke

Non-blocking note:

  • this is a prompt-only behavior change and I did not find automated coverage around these example strings, so there is still some model-behavior risk (especially around proactive agent invocation), but I did not find a concrete code-level regression in the current diff.

@kevincodex1 kevincodex1 merged commit 3188f6a into Gitlawb:main Apr 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants