Fix findNearestDialog for child of slotted element#222
Fix findNearestDialog for child of slotted element#222carmour24 wants to merge 1 commit intoGoogleChrome:masterfrom
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
A focus event for an element which is a child of a slotted element will be erroneously reported as not in the topmost dialog. This is because for the slotted element we should follow assignedSlot rather than the parentElement or parentNode to get the true hierarchy in which the elmeent lives. This change adds handling for slotted elements.
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Fix for issue #217.
A focus event for an element which is a child of a slotted element
will be erroneously reported as not in the topmost dialog. This is
because for the slotted element we should follow assignedSlot rather
than the parentElement or parentNode to get the true hierarchy in
which the elmeent lives. This change adds handling for slotted
elements.