feat(secretmanager): Adding tags samples#3295
feat(secretmanager): Adding tags samples#3295khilan-crest wants to merge 29 commits intoGoogleCloudPlatform:mainfrom
Conversation
…lan-crest/dotnet-docs-samples into cs_filter_cmek_samples
…est/dotnet-docs-samples into cs_expiretime_samples
Summary of ChangesHello @khilan-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the C# sample library for Google Cloud Secret Manager. It introduces new examples and corresponding unit tests for a wide array of features, including the creation and management of secrets with tags, expiration policies, annotations, and labels. Additionally, it provides guidance on using Customer-Managed Encryption Keys (CMEK) and demonstrates how to list secrets and their versions with specific filters. These additions aim to provide developers with practical, ready-to-use code snippets for integrating advanced Secret Manager capabilities into their applications. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces new samples and tests for managing tags, expiration, annotations, and CMEK for secrets in Secret Manager. It also includes updates to existing samples and their corresponding tests. The changes are generally well-structured and add valuable functionality. I've identified a few areas for improvement related to error handling in test helper methods, unused fields, and minor output message inconsistencies.
secretmanager/api/SecretManager.Samples.Tests/BindTagToRegionalSecretTests.cs
Outdated
Show resolved
Hide resolved
secretmanager/api/SecretManager.Samples.Tests/BindTagToRegionalSecretTests.cs
Show resolved
Hide resolved
secretmanager/api/SecretManager.Samples.Tests/BindTagToRegionalSecretTests.cs
Show resolved
Hide resolved
secretmanager/api/SecretManager.Samples.Tests/BindTagToRegionalSecretTests.cs
Outdated
Show resolved
Hide resolved
secretmanager/api/SecretManager.Samples.Tests/BindTagToRegionalSecretTests.cs
Outdated
Show resolved
Hide resolved
secretmanager/api/SecretManager.Samples/BindTagToRegionalSecret.cs
Outdated
Show resolved
Hide resolved
…est/dotnet-docs-samples into cs_expiretime_samples
…lan-crest/dotnet-docs-samples into cs_filter_cmek_samples
…est/dotnet-docs-samples into cs_expiretime_samples
…lan-crest/dotnet-docs-samples into cs_filter_cmek_samples
…est/dotnet-docs-samples into cs_expiretime_samples
Adding tags samples