Skip to content

Comments

feat(secretmanager): Adding tags samples#3295

Open
khilan-crest wants to merge 29 commits intoGoogleCloudPlatform:mainfrom
khilan-crest:cs_tag_samples
Open

feat(secretmanager): Adding tags samples#3295
khilan-crest wants to merge 29 commits intoGoogleCloudPlatform:mainfrom
khilan-crest:cs_tag_samples

Conversation

@khilan-crest
Copy link

Adding tags samples

@khilan-crest khilan-crest requested review from a team as code owners January 27, 2026 13:05
@snippet-bot
Copy link

snippet-bot bot commented Jan 27, 2026

Here is the summary of changes.

You are about to add 21 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Jan 27, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @khilan-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the C# sample library for Google Cloud Secret Manager. It introduces new examples and corresponding unit tests for a wide array of features, including the creation and management of secrets with tags, expiration policies, annotations, and labels. Additionally, it provides guidance on using Customer-Managed Encryption Keys (CMEK) and demonstrates how to list secrets and their versions with specific filters. These additions aim to provide developers with practical, ready-to-use code snippets for integrating advanced Secret Manager capabilities into their applications.

Highlights

  • New Samples for Secret Management: Introduced a comprehensive suite of new C# samples demonstrating various Google Cloud Secret Manager functionalities, including tag management, secret expiration, annotations, labels, and Customer-Managed Encryption Keys (CMEK).
  • Regional and Global Secret Operations: Added samples and tests for both regional and global secrets, ensuring broad coverage for different deployment scenarios within Secret Manager.
  • Tag Management Operations: New samples cover binding and detaching tags from secrets (both regional and global), as well as listing existing tag bindings.
  • Secret Metadata Management: Provided samples for creating secrets with expiration times, updating and deleting expiration settings, and managing secret annotations and labels.
  • Filtered Listing Capabilities: Included samples for listing secrets and secret versions using filters, enhancing discoverability and management of secrets.
  • CMEK Integration Samples: Added samples for creating secrets with Customer-Managed Encryption Keys (CMEK), showcasing enhanced security configurations.
  • Dependency Update: Updated the Google.Cloud.ResourceManager.V3 package reference from version 2.5.0 to 2.6.0 in the sample and test projects.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new samples and tests for managing tags, expiration, annotations, and CMEK for secrets in Secret Manager. It also includes updates to existing samples and their corresponding tests. The changes are generally well-structured and add valuable functionality. I've identified a few areas for improvement related to error handling in test helper methods, unused fields, and minor output message inconsistencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants