chore: fix legacy ENV syntax in Dockerfile#3341
Open
Ignorancio wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
chore: fix legacy ENV syntax in Dockerfile#3341Ignorancio wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Ignorancio wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Update ENV instructions to use the key=value format to resolve LegacyKeyValueFormat warnings during buildx execution. This ensures compatibility with modern Docker build engines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The
Dockerfilefor theshoppingassistantservicewas using the legacy space-separated format forENVinstructions. This triggered aLegacyKeyValueFormatwarning during thedocker buildprocess.Fixes
LegacyKeyValueFormatin theshopping-assistant-service.Change Summary
ENVdeclarations in the service'sDockerfileto use the recommendedkey=valueformat.Additional Notes
This change is purely a syntax update to comply with modern Docker best practices. It does not alter the environment variable values or the service's runtime behavior.
Testing Procedure