fix: pkg_resources not found + docker deprecated ENV, RUN errors - #3412
Open
adityak714 wants to merge 1 commit into
Open
fix: pkg_resources not found + docker deprecated ENV, RUN errors#3412adityak714 wants to merge 1 commit into
adityak714 wants to merge 1 commit into
Conversation
- Problem: When running `skaffold run` to locally compile on a Kind (Kubernetes in Docker) cluster, some services (such as the emailservice and loadgenerator) do not run. They are stuck in a crash loop, and required a pip-constraints file to ensure setup-tools is under version 82. The solution was thanks to a suggestion in https://stackoverflow.com/a/79886564 - Additionally, commands of ENV and RUN in dockerfile need an equal sign `=`, and in JSONArgs format respectively, which some Dockerfiles in `src/*` did not have. Now added in all Dockerfiles for consistency and for compilation to work. Reproducing: - Go to the specific service's folder in `src/` and do a docker build to inspect the changes, setting the destination as the folder itself. This is to inspect per-service compilation and if they build correctly or not. - Doing `skaffold run` from the root directory of this project (where the skaffold.yaml file is situated). - Skaffold version: GoogleContainerTools/skaffold@f9beeb7b6 - Kind version: 0.32.0 - Kubectl: - Client Version: v1.36.1 - Kustomize Version: v5.8.1 - Server Version: v1.36.1 - When doing skaffold run, a commonly occurring problem was the build suddenly stopping, leaving the creation of some services incomplete and interrupted. Repeating skaffold run multiple times was a temporary solution, but a timeout increase is needed. The suggested changes concern the following strand in the Product Requirements: 1. Preserve the golden user journey taken by Kubernetes beginners The following statement about Online Boutique should always be true: - A user outside of Google can deploy Online Boutique's default configuration on a kind Kubernetes cluster. Being able to run Online Boutique on a kind cluster ensures that Online Boutique is free and cloud-agnostic. This is aligned with Google's mission of making information universally accessible and useful. To be specific, Online Boutique should be useful and accessible to developers that are new to Kubernetes.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When running
skaffold runto locally compile on a Kind (Kubernetes in Docker) cluster, some services (such as the emailservice and loadgenerator) do not run. They are stuck in a crash loop, and required a pip-constraints file to ensure setup-tools is under version 82.=, and in JSONArgs format respectively, which some Dockerfiles insrc/*did not have.Fixes
Testing Procedure:
src/and do a docker build to inspect the changes, setting the destination as the folder itself. This is to inspect per-service compilation and if they build correctly or not.skaffold runfrom the root directory of this project (where the skaffold.yaml file is situated).Additional Notes
The suggested changes concern the following strand in the Product Requirements:
The following statement about Online Boutique should always be true:
Related PRs or Issues