Skip to content

Conversation

@grayjk
Copy link
Contributor

@grayjk grayjk commented Jul 14, 2025

No description provided.

@grayjk
Copy link
Contributor Author

grayjk commented Jul 14, 2025

is it also now safe to remove:

tests/test_adapter_py33.py
tests/test_descriptors_py36.py
tests/test_inheritance_py37.py
tests/test_formatargspec_py35.py
tests/test_class_py37.py

@grayjk
Copy link
Contributor Author

grayjk commented Jul 14, 2025

@GrahamDumpleton
Copy link
Owner

I don't believe it is safe to remove the files:

tests/test_adapter_py33.py
tests/test_descriptors_py36.py
tests/test_inheritance_py37.py
tests/test_formatargspec_py35.py
tests/test_class_py37.py

This is because the prefix says to only run these tests if the Python version matches or is greater than that in the file name suffix. So the files have to be left as is, or the tests integrated into the tests file without the version suffix.

I am probably happy just to leave the files as is at the moment rather than integrate them into non versioned test file as for now still leaves a record of which versions those tests started being valid for.

As to the `setup.py file, instead of:

    if platform.system() == "Windows" and sys.version_info[0] < 3:
        disable_extensions = True
        force_extensions = False
    else:
        disable_extensions = False
        force_extensions = False

should be okay to now use:

    disable_extensions = False
    force_extensions = False

@grayjk
Copy link
Contributor Author

grayjk commented Aug 4, 2025

I rebased on current develop branch. Let me know if you need any changes

@GrahamDumpleton GrahamDumpleton merged commit 3125a59 into GrahamDumpleton:develop Aug 4, 2025
45 checks passed
@grayjk grayjk deleted the other-cleanup branch August 4, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants