Open
Conversation
Up to standards ✅🟢 Issues
|
| Category | Results |
|---|---|
| Security | 3 high |
| CodeStyle | 2 minor |
🟢 Metrics 9 complexity · 3 duplication
Metric Results Complexity 9 Duplication 3
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 95.02% 96.21% +1.18%
==========================================
Files 31 31
Lines 1648 1690 +42
==========================================
+ Hits 1566 1626 +60
+ Misses 82 64 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR edits the
monte_carlo_fit.pysuch that the "best epoch" is chosen during training. This is the last epoch from which the validation loss improved with respect to the best validation loss throughout training AND the positivity datasets pass with a threshold of 1e-6. This "best epoch" is then used to produce the outputted optimised parametersThis matches the method used in NNPDF and may be useful for NTK analysis.
To Do: