Skip to content

Conversation

@max-ostapenko
Copy link
Contributor

Was part of the legacy repo: HTTPArchive/legacy.httparchive.org#85

Copilot AI review requested due to automatic review settings January 5, 2026 22:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tunetheweb
Copy link
Member

Let's go one step further and remove the library from third-parties.js custom-metric.

It looks like this was added in April 2017 but then a year later in March 2018 Wappalyzer support was added. As that's our preferred detection library and since lib-detector hasn't been updated in 5 years it's value is questionable. Let's ditch it completely.

However, as third-party is a custom-metric column, we still need to return this I presume? So maybe return a blank value for now and we can enhance it later (maybe with some almanac custom metric code if any third-party code in there - not checked)

@tunetheweb
Copy link
Member

FYI @pmeenan

@tunetheweb
Copy link
Member

Oh I also discovered that Lighthouse uses this library: https://github.com/search?q=repo%3AGoogleChrome%2Flighthouse+js-library-detector&type=code

And it appears there are newer versions and some activity on the repo: https://github.com/johnmichel/Library-Detector-for-Chrome/commits/main/

But I still vote to remove it since: 1) Wappalyzer is our preferred detection library and 2) We get all it gives in Lighthouse anyway! and 3) One less thing to manage (and forget to update for 5 years!)

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

https://almanac.httparchive.org/en/2022/

WPT result details

Changed custom metrics values:

{
  "_third-parties": null
}

@max-ostapenko
Copy link
Contributor Author

And Almanac 3P chapter actually uses another source based on https://github.com/patrickhulce/third-party-web

P.S. Here are the detected libraries in case we'd try to match the detections in Wappalyzer:

SELECT
  SAFE.STRING(third_party.name) AS name,
  COUNT(DISTINCT page) AS count_of_pages
FROM httparchive.crawl.pages,
  UNNEST(JSON_QUERY_ARRAY(custom_metrics.third_parties)) AS third_party
WHERE
  date = '2025-12-01' AND
  custom_metrics.third_parties IS NOT NULL
GROUP BY name
ORDER BY count_of_pages DESC

@max-ostapenko max-ostapenko changed the title Remove deprecated lib-detector-version.js Remove deprecated js-library-detector Jan 6, 2026
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@max-ostapenko max-ostapenko merged commit 15e3a1c into main Jan 6, 2026
4 checks passed
@max-ostapenko max-ostapenko deleted the inclined-boa branch January 6, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants