Actions workflow to sync icons to the bucket #94
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,45 +1,91 @@ | ||
| name: Upload technologies to BQ and Cloud Storage | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - ".github/workflows/upload.yml" | ||
| - "src/technologies/*.json" | ||
| - "src/categories.json" | ||
| - "src/groups.json" | ||
| - "src/images/icons/**" | ||
| workflow_dispatch: | ||
| inputs: | ||
| force_update: | ||
| description: 'Force update regardless of changes' | ||
| required: false | ||
| default: 'false' | ||
max-ostapenko marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| jobs: | ||
| test: | ||
| name: Test and upload to GCP | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
|
|
||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install | ||
|
|
||
| - name: Validate | ||
| run: yarn run validate | ||
|
|
||
| - name: Get changed technology files | ||
| run: | | ||
| git log -1 HEAD^ | ||
| git log -1 HEAD | ||
|
|
||
| git fetch origin main --depth=1 | ||
| TECH_FILES_CHANGED=$(git diff --name-only HEAD^ HEAD -- 'src/technologies/*.json' 'src/categories.json' 'src/groups.json' | wc -l) | ||
| echo $TECH_FILES_CHANGED | ||
| echo "TECH_FILES_CHANGED=${TECH_FILES_CHANGED}" >> $GITHUB_ENV | ||
|
|
||
| - name: Upload technology rules to BigQuery | ||
| if: env.TECH_FILES_CHANGED != '' || inputs.force_update == 'true' | ||
| env: | ||
| GCP_SA_KEY: ${{ secrets.GCP_SA_KEY }} | ||
| run: yarn run tech_upload | ||
|
|
||
| - name: Get changed icons | ||
| run: | | ||
| git fetch origin main --depth=1 | ||
|
|
||
| if [[ "${{ inputs.force_update }}" == "true" ]]; then | ||
| CHANGED_ICONS=$(find src/images/icons -name "*.svg" -o -name "*.png" | xargs) | ||
| else | ||
| CHANGED_ICONS=$(git diff --name-only HEAD^ HEAD -- 'src/images/icons/*.svg' 'src/images/icons/*.png' | xargs) | ||
| fi | ||
|
|
||
| echo $CHANGED_ICONS | ||
| echo "CHANGED_ICONS=${CHANGED_ICONS}" >> $GITHUB_ENV | ||
|
|
||
| # PNG are generally smaller, and we have some SVG that are 1Mb, so conversion to PNG is necessary. | ||
| - name: Install Image Conversion Package | ||
| if: env.CHANGED_ICONS != '' | ||
| run: sudo apt-get install -y librsvg2-bin | ||
|
|
||
| - name: Convert changed SVGs to PNGs | ||
| if: env.CHANGED_ICONS != '' | ||
| run: | | ||
| for file in $CHANGED_ICONS; do | ||
| if [[ "$file" == *.svg ]]; then | ||
| rsvg-convert "$file" -o "${file%.svg}.png" -w 16 -h 16 | ||
| fi | ||
| done | ||
|
Comment on lines
+71
to
+78
Member
There was a problem hiding this comment. Why can't we use SVGs if in that format already? Maybe add a comment to explain?
Contributor
Author
There was a problem hiding this comment. PNG are generally smaller, and we have some SVG that are 1Mb. |
||
|
|
||
| - uses: 'google-github-actions/auth@v2' | ||
| if: env.CHANGED_ICONS != '' || inputs.force_update == 'true' | ||
| with: | ||
| credentials_json: ${{ secrets.GCP_SA_KEY }} | ||
|
|
||
| - uses: 'google-github-actions/setup-gcloud@v2' | ||
| if: env.CHANGED_ICONS != '' || inputs.force_update == 'true' | ||
|
|
||
| - name: Sync new PNGs to Cloud Storage | ||
| if: env.CHANGED_ICONS != '' || inputs.force_update == 'true' | ||
| run: | | ||
| gcloud storage rsync src/images/icons/ gs://httparchive/static/icons/ --exclude=".*.svg$" --cache-control="public, max-age=31536000, immutable" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -208,3 +208,5 @@ fs.readdirSync(iconPath).forEach((file) => { | |
| } | ||
| } | ||
| }) | ||
|
|
||
| console.log('Validation completed successfully.') | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we exclude these?
Most of our contributions are to these files and I'd like to lint them.