Refactor AssetDirectoryReaderTest to use light fixture#2721
Merged
Conversation
utafrali
approved these changes
Apr 7, 2026
utafrali
left a comment
utafrali
left a comment
There was a problem hiding this comment.
Clean refactoring that migrates the test to a lighter, faster fixture base class. The bundled fix of orElseGet(null) to orElse(null) is a real correctness improvement. The only minor issue is the use of the deprecated getBaseDir() API.
src/test/java/fr/adrienbrault/idea/symfony2plugin/tests/asset/AssetDirectoryReaderTest.java
Show resolved
Hide resolved
|
|
||
| assertNotNull(new AssetDirectoryReader() | ||
| .resolveAssetFile(getProject(), "test.js").stream() | ||
| .filter(virtualFile -> "test.js".equals(virtualFile.getName())) |
There was a problem hiding this comment.
Worth calling out: the switch from .orElseGet(null) to .orElse(null) is a correctness fix, not just a style cleanup. Passing null to orElseGet throws a NullPointerException at runtime because it expects a non-null Supplier<T>. This bug was silently masked by the old temp fixture approach if those code paths were never actually hit with a missing file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.