Conversation
The ESP-Box variants have a separate audio board codec and ADC, so we do not need to enable the ADC on the audio board codec (es8311).
Fixes: 18715d0e3e8c ("log: set I2C log level")
This is to prevent a crash when the notify task is started if the ESP Audio player is not yet initialized.
Booting with mute active often results in the I2C bus being completely defunct, causing log spam of I2C errors. The mute check was previously moved after audio init in commit 20780c4 ("audio: initialize amp before mute check") so that WAS locate would work even if the device is waiting to be unmuted. Unfortunately it seems prohibitively difficult to make that work reliably, so to not spend any more time debugging that, the move check is moved back before audio init. This is not ideal, but I've spent way too much time on debugging this issue already, and I rather avoid the log spam. The mute check was moved after audio init to solve #319, but Willow connects to WAS before the mute check, and commands sent from WAS actually execute, there just won't be any audio output. In case of WAS locate, the display would still light up. Fixes: #415
This is to prevent a crash when playing audio if the ESP Audio player is not initialized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.