audio: set HTTP stream timeout after connect#444
Merged
Conversation
In commit 67ff035 ("audio: increase HTTP stream timeout after send") we increased the timeout for the HTTP stream to WIS STT after send to 10s, to allow people with slow WIS to still use Willow. For some reason this worked in the 0.3 releases, but it seems this doesn't work anymore after all the bumps of Espressif components in the 0.4 releases. The commit was wrong in the first place, as we should increase the timeout after initial connect, but before we finish sending, as setting it after we finished sending should result in the connection timing out after 2s while sending. Set the timeout on the HTTP_STREAM_ON_REQUEST event to fix this. Fixes: 67ff035 ("audio: increase HTTP stream timeout after send")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In commit 67ff035 ("audio: increase HTTP stream timeout after send") we increased the timeout for the HTTP stream to WIS STT after send to 10s, to allow people with slow WIS to still use Willow. For some reason this worked in the 0.3 releases, but it seems this doesn't work anymore after all the bumps of Espressif components in the 0.4 releases.
The commit was wrong in the first place, as we should increase the timeout after initial connect, but before we finish sending, as setting it after we finished sending should result in the connection timing out after 2s while sending.
Set the timeout on the HTTP_STREAM_ON_REQUEST event to fix this.
Fixes: 67ff035 ("audio: increase HTTP stream timeout after send")