misc: add issue link for hatch workaround - #251058
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates comments across multiple Homebrew formula files to clarify the reason for setting SOURCE_DATE_EPOCH to "1451574000". The change replaces misleading comments that suggested the source code lacked a valid SOURCE_DATE_EPOCH with accurate comments explaining that hatch (the build backend) doesn't support values before 1980. The updated comments also include a reference to the upstream issue that will fix this limitation.
Key changes:
- Replaced inaccurate comment text with technically correct explanation
- Added issue link for tracking when the workaround can be removed
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Formula/v/vunnel.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/t/terraform-iam-policy-validator.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/s/streamrip.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/s/snakefmt.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/s/sigma-cli.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/s/sherlock.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/s/sceptre.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/s/sarif-tools.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/r/rich-cli.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/r/remarshal.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/p/prowler.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/p/poetry.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/p/podcast-archiver.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/o/otterdog.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/m/manim.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/m/mac-cleanup-py.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/l/literate-git.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/k/kaskade.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/j/jrnl.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/j/jiratui.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/g/gptme.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/d/dooit.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/d/dolphie.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/c/cyclonedx-python.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/c/copier.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/c/commitizen.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/c/codelimit.rb | Updated comment to clarify hatch limitation and added issue reference |
| Formula/b/bbot.rb | Updated comment to clarify hatch limitation and added issue reference |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
daeho-ro
approved these changes
Oct 25, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Hatch currently does not correctly handle a
SOURCE_DATE_EPOCHbefore 1980 like other build backends. This will be fixed when pypa/hatch#1999 is released, so let's clarify these misleading comments