Skip to content

Replace author Edit button with new window link icon #4856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wes-otf merged 2 commits into from
May 22, 2026
+3 −3
Merged

Replace author Edit button with new window link icon #4856

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3055459
Replaced `Edit` button with new window link icon
wes-otf May 21, 2026
92059d9
Added title to anchor element
wes-otf May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hypha/apply/funds/templates/funds/includes/rendered_answers.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ <h3 class="pb-2 mb-2 font-medium border-b text-h3">
{% if object|show_applicant_identity:request.user %}
<div class="fieldset">
<dt class="font-semibold">{% trans "Legal Name" %}</dt>
<dd class="flex gap-2 items-center">
<dd class="flex gap-1 items-center">
{{ object.get_full_name_display }}
{% if request.user.is_apply_staff %}
<a class="link" href="{% url 'wagtailusers_users:edit' object.user_id %}">
{% trans "Edit" %}
<a class="link" title="{% trans 'Edit user account' %}" href="{% url 'wagtailusers_users:edit' object.user_id %}" target="_blank">
{% heroicon_mini "arrow-top-right-on-square" class="inline align-text-bottom size-4" aria_hidden=true %}
</a>
Copy link
Copy Markdown
Member

@frjo frjo May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That icon usually is used for external links. Can we not just make it underline?

Not to fond of target="_blank" but we use it in 25 other places already.

Copy link
Copy Markdown
Contributor Author

@wes-otf wes-otf May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was using some of the precedent here to convey to the staff member that this is going to remove them from their current workflow, as I can see a lot of them clicking it accidentally thinking it'll allow for filtering by applicant or something similar. Can make the name a link if you feel that's more intuitive though

Copy link
Copy Markdown
Member

@frjo frjo May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let leave it as is. But we do need to add a "title" attribute to the link to make it accessible. Something like "Edit user account".

Copy link
Copy Markdown
Contributor Author

@wes-otf wes-otf May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be set now!

{% endif %}
</dd>
Expand Down