Skip to content

[Security][ICACF-16] Strengthen account lockout to prevent brute-force attacks #4348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohanLaksh wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −15
Open

[Security][ICACF-16] Strengthen account lockout to prevent brute-force attacks #4348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51cfc7f
security(auth): strengthen account lockout to prevent brute-force att…
MohanLaksh Apr 20, 2026
55a9429
chore: update secrets baseline line numbers
MohanLaksh Apr 22, 2026
57f50bf
Merge branch 'main' into fix/icacf-16-account-lockout-config
MohanLaksh Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,10 +976,14 @@ OTEL_EXPORTER_OTLP_ENDPOINT=http://localhost:4317
# PASSWORD_MAX_AGE_DAYS=90

# Account Security Configuration
# Maximum failed login attempts before account lockout
# MAX_FAILED_LOGIN_ATTEMPTS=10
# Account lockout duration in minutes
# ACCOUNT_LOCKOUT_DURATION_MINUTES=1
# Maximum failed login attempts before account lockout (recommended: 5)
# Production deployments should use the default value (5) or lower to prevent brute-force attacks
# Security Note: Per ICACF-16, accounts are locked after 5 failed attempts within 60 minutes
# MAX_FAILED_LOGIN_ATTEMPTS=5
# Account lockout duration in minutes (recommended: 60)
# Locks account for this duration after MAX_FAILED_LOGIN_ATTEMPTS is exceeded
# Security Note: Per ICACF-16, 60-minute lockout prevents brute-force attacks
# ACCOUNT_LOCKOUT_DURATION_MINUTES=60
# Send lockout notification emails when an account is locked
# ACCOUNT_LOCKOUT_NOTIFICATION_ENABLED=true
# Minimum response time for failed login attempts (milliseconds)
Expand Down
18 changes: 9 additions & 9 deletions .secrets.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,71 +108,71 @@
"hashed_secret": "fa9beb99e4029ad5a6615399e7bbae21356086b3",
"is_secret": false,
"is_verified": false,
"line_number": 1011,
"line_number": 1015,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "7b4455a56fbf1d198e45e04c437488514645a82c",
"is_secret": false,
"is_verified": false,
"line_number": 1037,
"line_number": 1041,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "ac371b6dcce28a86c90d12bc57d946a800eebf17",
"is_secret": false,
"is_verified": false,
"line_number": 1117,
"line_number": 1121,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "0b6ec68df700dec4dcd64babd0eda1edccddace1",
"is_secret": false,
"is_verified": false,
"line_number": 1122,
"line_number": 1126,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "4ad6f0082ee224001beb3ca5c3e81c8ceea5ed86",
"is_secret": false,
"is_verified": false,
"line_number": 1127,
"line_number": 1131,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "cb32747fcfb55eaa194c8cd8e4ba7d49ada08a94",
"is_secret": false,
"is_verified": false,
"line_number": 1133,
"line_number": 1137,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "6c178d51b13520496dbc767ed3d9d7aa5803ac72",
"is_secret": false,
"is_verified": false,
"line_number": 1145,
"line_number": 1149,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "ca45060a53fd8a255d1a83ee8d2f025283ccc66e",
"is_secret": false,
"is_verified": false,
"line_number": 1163,
"line_number": 1167,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "910fbf00f58e9bcb095ea26a75cc1d9a3355e671",
"is_secret": false,
"is_verified": false,
"line_number": 1224,
"line_number": 1228,
"type": "Secret Keyword",
"verified_result": null
}
Expand Down
4 changes: 2 additions & 2 deletions mcpgateway/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,8 +696,8 @@ class Settings(BaseSettings):
password_prevent_reuse: bool = Field(default=True, description="Prevent reusing the current password when changing")
password_max_age_days: int = Field(default=90, description="Password maximum age in days before expiry forces a change")
# Account Security Configuration
max_failed_login_attempts: int = Field(default=10, description="Maximum failed login attempts before account lockout")
account_lockout_duration_minutes: int = Field(default=1, description="Account lockout duration in minutes")
max_failed_login_attempts: int = Field(default=5, description="Maximum failed login attempts before account lockout")
account_lockout_duration_minutes: int = Field(default=60, description="Account lockout duration in minutes")
account_lockout_notification_enabled: bool = Field(default=True, description="Send lockout notification emails when accounts are locked")
failed_login_min_response_ms: int = Field(default=250, description="Minimum response duration for failed login attempts to reduce timing side channels")

Expand Down
Loading