chore: update pyspelling to use uv tool run and add transitive dependency pins - #4386
Merged
Conversation
jonpspri
requested review from
brian-hussey,
crivetimihai,
dawid-nowak,
dima-zakharov and
lucarlig
as code owners
April 22, 2026 10:38
dawid-nowak
previously approved these changes
Apr 22, 2026
jonpspri
force-pushed
the
jps-housekeeping-04-22
branch
from
April 23, 2026 08:34
69b3713 to
14f812c
Compare
Allow IMAGE_LOCAL to be overridden externally for docker compose commands. This enables flexible environment setup with custom images via commands like 'make testing-up IMAGE_LOCAL=custom-image:tag'. Changes: - Wrap IMAGE_LOCAL definition in ifndef block to allow external override - Add echo statement in testing-up to show which image is being used - Maintains backward compatibility with existing workflows This improves developer experience by allowing easy testing with different image builds without modifying the Makefile. Signed-off-by: Jonathan Springer <jps@s390x.com>
jonpspri
force-pushed
the
jps-housekeeping-04-22
branch
from
April 23, 2026 08:40
14f812c to
a7a1eff
Compare
gcgoncalves
pushed a commit
that referenced
this pull request
Apr 23, 2026
Allow IMAGE_LOCAL to be overridden externally for docker compose commands. This enables flexible environment setup with custom images via commands like 'make testing-up IMAGE_LOCAL=custom-image:tag'. Changes: - Wrap IMAGE_LOCAL definition in ifndef block to allow external override - Add echo statement in testing-up to show which image is being used - Maintains backward compatibility with existing workflows This improves developer experience by allowing easy testing with different image builds without modifying the Makefile. Signed-off-by: Jonathan Springer <jps@s390x.com>
brian-hussey
pushed a commit
that referenced
this pull request
May 5, 2026
Allow IMAGE_LOCAL to be overridden externally for docker compose commands. This enables flexible environment setup with custom images via commands like 'make testing-up IMAGE_LOCAL=custom-image:tag'. Changes: - Wrap IMAGE_LOCAL definition in ifndef block to allow external override - Add echo statement in testing-up to show which image is being used - Maintains backward compatibility with existing workflows This improves developer experience by allowing easy testing with different image builds without modifying the Makefile. Signed-off-by: Jonathan Springer <jps@s390x.com> Signed-off-by: Brian Hussey <brian.hussey@ie.ibm.com>
msureshkumar88
pushed a commit
that referenced
this pull request
May 13, 2026
Allow IMAGE_LOCAL to be overridden externally for docker compose commands. This enables flexible environment setup with custom images via commands like 'make testing-up IMAGE_LOCAL=custom-image:tag'. Changes: - Wrap IMAGE_LOCAL definition in ifndef block to allow external override - Add echo statement in testing-up to show which image is being used - Maintains backward compatibility with existing workflows This improves developer experience by allowing easy testing with different image builds without modifying the Makefile. Signed-off-by: Jonathan Springer <jps@s390x.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
uv tool runfor pyspelling instead of venv-installed binaryTesting
make spellcheckto verify pyspelling works via uv tool runuv syncto verify dependency resolution with new pins