Add project description to PyPI page - #178
Merged
Merged
Conversation
README.md is not included in binary distributions (i.e: wheel builds) so a source distribution needs to be created as well. Signed-off-by: Antonio Gutierrez <chibby0ne@gmail.com>
Member
|
thanks! i see you added |
Contributor
Author
Yeah you're right. It seems it doesn't upload the sdist at the moment 🤔 spnl/.github/workflows/publish_pypi.yml Lines 35 to 39 in 0e2395a spnl/.github/workflows/publish_pypi.yml Lines 52 to 61 in 0e2395a Another PR is in order then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently spnl PyPI page has no project description. This is due to the
pyproject.tomlnot including the README.md section.In addition to that README.md specified in
pyproject.tomlare not included in binary distributions (i.e: wheel builds) so a source distribution needs to be created as well.In addition made a small refactor of the
--featuresflag ofmaturin buildaccording to the documentation.