Update get-extensions and setup-environment logic for new major release of extensions#1768
Open
mrmundt wants to merge 8 commits intoIDAES:mainfrom
Open
Update get-extensions and setup-environment logic for new major release of extensions#1768mrmundt wants to merge 8 commits intoIDAES:mainfrom
mrmundt wants to merge 8 commits intoIDAES:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1768 +/- ##
==========================================
- Coverage 73.83% 73.81% -0.02%
==========================================
Files 419 419
Lines 66225 66323 +98
Branches 11122 11156 +34
==========================================
+ Hits 48894 48957 +63
- Misses 14794 14821 +27
- Partials 2537 2545 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1248, #1583 , #1562 , #1536
Summary/Motivation:
Who wants new extension versions?
WE DO!
This PR implements the changes necessary to support both old and new versions of IDAES extensions in a lovely, compatible way. There are probably a plethora of opportunities for debate on exact implementations, so go forth and argue.
That being said, this does currently work for both <4 and >=4 releases. NOTE that I know there are some failing tests, and I am going to need some guidance/help on how to fix them. I wanted this open for the visibility of those and to enable discussion.
Changes proposed in this PR:
bin_directory; be more layout/release awareLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: