Fix Hydra config loading to support custom config paths and prevent reinitialization errors#101
Open
anujonthemove wants to merge 2 commits intoIDEA-Research:mainfrom
Open
Fix Hydra config loading to support custom config paths and prevent reinitialization errors#101anujonthemove wants to merge 2 commits intoIDEA-Research:mainfrom
anujonthemove wants to merge 2 commits intoIDEA-Research:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Hydra config loading issues by using initialize_config_dir to support custom config paths and prevent reinitialization errors.
- Implements proper Hydra initialization by clearing GlobalHydra state before configuration loading.
- Adds a config_root parameter in build_sam2 for user-specified configuration directory paths.
- Updates the demo script to match the new local configuration path structure.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sam2/build_sam.py | Refactors build_sam2 to use initialize_config_dir, clears GlobalHydra if already initialized, and adds a config_root parameter. |
| grounded_sam2_local_demo.py | Updates SAM2_MODEL_CONFIG to reflect the new local config path format. |
Comments suppressed due to low confidence (1)
sam2/build_sam.py:118
- The variable 'config_file' is referenced in the compose() call but is not defined in the function signature. Consider adding 'config_file' as an explicit parameter to avoid potential runtime errors.
cfg = compose(config_name=config_file, overrides=hydra_overrides_extra)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
build_sam2()function to use Hydra’s recommendedinitialize_config_dir()pattern, resolving configuration loading issues and enabling flexible, reusable model initialization.✅ Key Changes:
compose()-only approach withinitialize_config_dir()to support loading configs from custom local paths (config_root).GlobalHydra already initializedruntime errors.📌 How can this help:
Custom Config Support:
The original code assumed Hydra could locate the config via its default search path, which failed for local or container-mounted configs. This change enables users to explicitly specify the root directory for config files.
Hydra Reinitialization Error Fix:
In scripts or interactive sessions (e.g., notebooks, demos), Hydra throws a
GlobalHydra is already initializederror when reused. This patch handles such cases safely.Improved Portability:
The updated implementation ensures reliable config loading across environments, including containers, distributed jobs, and non-Hydra CLI contexts.