Skip to content

Fixed N+1 query in SMP view #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
justcool0208 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed N+1 query in SMP view #307

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8a9a58
Fixed N+1 query in SMP view
justcool0208 Mar 17, 2026
3d5663c
Merge branch 'main' into SMP_N+1_Query_Fix
justcool0208 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion corpus/smp/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from django.contrib import messages
from django.contrib.auth.decorators import login_required
from django.db.models import Count
from django.db.models import Prefetch
from django.shortcuts import get_object_or_404
from django.shortcuts import redirect
from django.shortcuts import render
Expand Down Expand Up @@ -58,6 +59,17 @@ def programs_by_year(request, year):
except (ValueError, TypeError):
pass

programs = programs.prefetch_related(
Prefetch(
'programmember_set__member__executivemember__sig',
queryset=SIG.objects.distinct(),
to_attr='sigs_list'
)
)

for program in programs:
program.sigs = program.sigs_list

return render(
request,
"smp/programs_by_year.html",
Expand Down Expand Up @@ -309,4 +321,4 @@ def create_submission(request, upload_id):
request,
"smp/create_submission.html",
{"form": form, "upload": upload, "program": program},
)
)
Loading