add cascade for dataverse delete with metrics

[stevenwinship]

What this PR does / why we need it: dataverse delete fails if there are cached metrics due to a foreign key constraint

Which issue(s) this PR closes: #12030

• Closes Unable to delete Dataverse when a row exists in the metrics table #12030

Special notes for your reviewer:

Suggestions on how to test this: create/publish dataverse. request metrics to cause a cached row in metric table. Delete the dataverse

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

[coveralls]

coverage: 24.314%. remained the same
when pulling 88d280d on 12030-unable-to-delete-dataverse-with-metrics
into f214ee4 on develop.

[qqmyers]

I don't think this would usually be generated (with the ON DELETE CASCADE part) - the Cascade remove annotation works at the ORM layer. At least I haven't seen it before looking at the table descriptions for other places we have cascade remove annotations. I guess I'd suggest seeing if the remove works without changing the db constraint if you haven't already.

[stevenwinship]

I re-tested everything and the annotation on Metric didn't do anything. The only change that works is the constraint change in this sql

[stevenwinship]

I tested both with upgraded db/dataverse and new db

[qqmyers]

Hmm - that seems like a problem - what annotations did you try? Orphan?

[qqmyers]

Are we missing the equivalent of

dataverse/src/main/java/edu/harvard/iq/dataverse/Dataset.java

Lines 144 to 145 in 70b6e26

	@OneToMany(mappedBy = "dataset", orphanRemoval = true, cascade = {CascadeType.REMOVE, CascadeType.MERGE, CascadeType.PERSIST})
	private List<DatasetMetrics> datasetMetrics = new ArrayList<>();

for Dataverse/Metric ?

[stevenwinship]

yes. Dataverse doesn't have that. There is no DataverseMetrics class

[stevenwinship]

added
@OneToMany(mappedBy = "dataverse", orphanRemoval = true, cascade = {CascadeType.REMOVE, CascadeType.MERGE, CascadeType.PERSIST}) private List<Metric> dataverseMetrics = new ArrayList<>();

[github-actions]

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12030-unable-to-delete-dataverse-with-metrics

ghcr.io/gdcc/configbaker:12030-unable-to-delete-dataverse-with-metrics

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

[qqmyers]

Seems reasonable. I wonder if we actually need the cascade parts since we don't create metrics via the Dataverse object. (Same for Dataset probably). That said, it should work as written.

[sekmiller]

It does what it purports to do. - if there are records on the metric table I can still delete the dataverse and the metric record is also deleted.
I did find a couple of anomalies with the get Metrics API. If you call it with a parentAlias that exists but isn't published it will return a value (in my case the total number of dataverses in my local db). It doesn't create a record in the metric table. If you call it with a parentAlias that doesn't exist you get an "Api endpoint doesn't exist error" not a dataverse not found error. Out of scope for this, but possibly worth fixing?