Resets the appStack when the display is automatically moved back to to the watch face - #2460
Open
SteveAmor wants to merge 1 commit into
Open
Resets the appStack when the display is automatically moved back to to the watch face#2460SteveAmor wants to merge 1 commit into
SteveAmor wants to merge 1 commit into
Conversation
|
Build size and comparison to main:
|
1 task
Contributor
Author
|
Tested on PineTime hardware and it works as expected and I can't force it into a bad state as per the process in #2461 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Button presses and gestures to move to another screen pop the previous screen off the App Stack.
When the display times out to go to sleep, if you are on the Notifications or Settings screen, the display automatically goes back to the watch face. This change in screen isn't popped off the App Stack which eventually fills the appStack and causes a button press to jump straight to the watch face rather than the previous screen.
Given the watch face can be considered as the top level screen, this PR prevents the stack overflow/stale-entry behaviour. This is in fact what happens when you do a button:longPress