-
Notifications
You must be signed in to change notification settings - Fork 63
ci: add labeler #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add labeler #153
Conversation
Summary of ChangesHello @ChenZiHong-Gavin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a GitHub Action to automate the labeling of pull requests. By defining specific file path patterns in a new configuration file, PRs will automatically receive relevant labels, which will enhance repository organization and streamline the review process by making it easier to identify the scope of changes at a glance. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a GitHub Actions labeler configuration to automate PR labeling. The configuration has a critical syntax error that will prevent it from working. I've provided a suggestion to fix the YAML syntax and also to improve the pattern for matching workflow files. With these changes, the labeler should work as intended.
.github/pr-labeler.yml
Outdated
| core: | ||
| - graphgen/**/* | ||
|
|
||
| examples: | ||
| - examples/**/* | ||
|
|
||
| baselines: | ||
| - baselines/**/* | ||
|
|
||
| documentation: | ||
| - "**/*.md" | ||
|
|
||
| workflows: | ||
| - .github/workflows/*.yml | ||
|
|
||
| config: | ||
| - .github/labeler.yml | ||
| - .pre-commit-config.yaml | ||
| - .pylintrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The YAML syntax in this file is invalid because list items are not indented under their keys. This will cause the labeler action to fail. I've corrected the indentation and also expanded the workflows pattern to include .yaml files, as GitHub Actions supports both .yml and .yaml extensions.
core:
- graphgen/**/*
examples:
- examples/**/*
baselines:
- baselines/**/*
documentation:
- "**/*.md"
workflows:
- .github/workflows/*.yml
- .github/workflows/*.yaml
config:
- .github/labeler.yml
- .pre-commit-config.yaml
- .pylintrc|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces automated labeling for issues and pull requests, which is a great step for repository organization. The configuration for issue labeling is well-structured, and I've suggested a few additional keywords to enhance its accuracy. For the pull request labeler, I've identified a critical issue in a file path for the configuration files themselves and proposed a fix to ensure changes to the labeler setup are correctly tracked.
| @@ -0,0 +1,10 @@ | |||
| bug: | |||
| - '\b(bug|error|fail|crash|defect|broken)\b' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - 'Bug report' | ||
|
|
||
| enhancement: | ||
| - '\b(feature|request|idea|proposal|improve|add)\b' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - 'Feature request' | ||
|
|
||
| question: | ||
| - '\b(question|help|how to|support|query)\b' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR automates pull request labeling for better repository organization.