Moves code from amRdash to amR_shiny. - #1
Merged
Conversation
eboyer221
requested review from
AbhirupaGhosh,
charmvang,
epbrenner,
jananiravi and
the-mayer
January 14, 2026 20:10
@eboyer221, I think what you had in amRdash worked well. was that the outcome of your discussion with @the-mayer as well? this still needs some cleanup - rm ESKAPE-specific calls - generalize - rm library and source calls - rm hardcoded paths Co-Authored-By: Emily Boyer <130874527+eboyer221@users.noreply.github.com> Co-Authored-By: D Mayer <32186106+the-mayer@users.noreply.github.com>
Replaced golem-based app structure with the single `launchAMRDashboard` function we discussed yesterday, removed golem-specific files and configuration, and updated UI module loading to use internal functions. Updated DESCRIPTION and NAMESPACE to reflect new dependencies and exports, and cleans up test infrastructure to match the new package name and structure. No errors for now. Few warnings and notes to fix. More on Slack. cc: @eboyer221 @the-mayer Co-Authored-By: Emily Boyer <130874527+eboyer221@users.noreply.github.com>
Member
|
@eboyer221 @AbhirupaGhosh, you also need to make sure the hardcoded ESKAPE bugs/code lines are removed. I added Eco, Sepi, Cje to your list. If you want to prepopulate, then these 2–3 might be better examples (@epbrenner @AbhirupaGhosh can confirm). Eventually, whether they're running it with 1 or more species should be a user-driven decision. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates changes from amRdash to amR_shiny.