Dividing Setting string into Visual and self#6
Open
JackTriton wants to merge 1 commit intoReLanguagefrom
Open
Conversation
|
I recommend holding off on this for now. The addition of a second settings string is something that I'd expect would have major impact on the OoTR infrastructure. |
Owner
Author
|
@fenhl Could I inform about this on the discord? |
|
What do you mean? |
Owner
Author
|
@fenhl About separating the Settings String into 2 different strings as the solution |
|
Of course, you're always free to discuss ongoing development in #dev-public-talk. I've also pinged the ootrandomizer.com admins to request their input. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Divide Settings String into Visual Settings String and Settings String
This allows to share the information about Language and any other visual settings while keeping the compatibility for Seed