feat(dev): lint and format cypress tests#350
Draft
themightychris wants to merge 13 commits intodevelopfrom
Draft
feat(dev): lint and format cypress tests#350themightychris wants to merge 13 commits intodevelopfrom
themightychris wants to merge 13 commits intodevelopfrom
Conversation
The community seems to recommend this as prettier is _more_ opinionated
Member
Author
|
The work setting up eslint in SlateFoundation/slate-cbl#586 might be relevant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Camus1859 's original work from #349 plus some work I did to try and get it working consistently before running into prettier v2 having deadend issues formatting Cypress test sanely: prettier/prettier#7884
It looks like the options are to lock to prettier v1 or just apply eslint and disable prettier