chore: simplify monitor matching by just checking geometry#984
Open
davfsa wants to merge 2 commits intoJas-SinghFSU:masterfrom
Open
chore: simplify monitor matching by just checking geometry#984davfsa wants to merge 2 commits intoJas-SinghFSU:masterfrom
davfsa wants to merge 2 commits intoJas-SinghFSU:masterfrom
Conversation
Signed-off-by: davfsa <davfsa@gmail.com>
Signed-off-by: davfsa <davfsa@gmail.com>
Owner
|
To me this looks like it would add a regression in matching monitors where GDK scaling is different than Hyprland scaling, hence throwing the pixel coordinates off, no? |
lika85456
added a commit
to lika85456/HyprPanel
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of the code I believe could be simplified, but didnt bother with that for now