Skip to content

Lexer: Support #warnon #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DedSec256 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Lexer: Support #warnon #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcc187e
Lexer: support #warnon
DedSec256 Nov 21, 2025
8efb19f
rebase
DedSec256 Feb 24, 2026
c31f0d0
fix test
DedSec256 Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rper.FSharp/src/FSharp/FSharp.Psi.Features/src/CodeCompletion/Rules/FSharpKeywordsRule.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ type FSharpKeywordsRule() =
let hashDirectives isFSharp9Supported =
let spaceOrQuotesSuffix = if isFSharp9Supported then KeywordSuffix.Space else KeywordSuffix.Quotes

[| spaceOrQuotesSuffix, [| "#nowarn"; "#time" |]
[| spaceOrQuotesSuffix, [| "#nowarn"; "#warnon"; "#time" |]
KeywordSuffix.Quotes, [| "#load"; "#r"; "#I" |]
KeywordSuffix.None, [| "#if"; "#else"; "#endif" |] |]

Expand Down
1 change: 1 addition & 0 deletions ReSharper.FSharp/src/FSharp/FSharp.Psi/src/Parsing/FSharpTokens.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@
<Token name="PP_ELSE_SECTION" representation="#else" />
<Token name="PP_ENDIF" representation="#endif" />
<Token name="PP_NOWARN" representation="#nowarn" />
<Token name="PP_WARNON" representation="#warnon" />

<Token name="PP_OR" representation="||" />
<Token name="PP_AND" representation="&amp;&amp;" />
Expand Down
1 change: 1 addition & 0 deletions ReSharper.FSharp/src/FSharp/FSharp.Psi/src/Parsing/Lexing/FSharpRules.lex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,7 @@ PP_CONDITIONAL_SYMBOL={IDENT}
<PPDIRECTIVE> {HASH}"time" { yybegin(LINE); return MakeToken(PP_TIME); }
<PPDIRECTIVE> {HASH}"I" { yybegin(LINE); return MakeToken(PP_I); }
<PPDIRECTIVE> {HASH}"nowarn" { yybegin(LINE); return MakeToken(PP_NOWARN); }
<PPDIRECTIVE> {HASH}"warnon" { yybegin(LINE); return MakeToken(PP_WARNON); }

<PPDIRECTIVE> {HASH}"if" { yypushback(yylength()); yybegin(PPSHARP); Clear(); break; }
<PPDIRECTIVE> {HASH}"else" { yypushback(yylength()); yybegin(PPSHARP); Clear(); break; }
Expand Down
1 change: 1 addition & 0 deletions ReSharper.FSharp/test/data/features/completion/Local val - Op 01.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#nowarn
#r
#time
#warnon
ADVF (in System.Runtime.InteropServices.ComTypes)
ASCIIEncoding (in System.Text)
AbandonedMutexException (in System.Threading)
Expand Down
1 change: 1 addition & 0 deletions ReSharper.FSharp/test/data/features/completion/Local val - Op 02.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#nowarn
#r
#time
#warnon
ADVF (in System.Runtime.InteropServices.ComTypes)
ASCIIEncoding (in System.Text)
AbandonedMutexException (in System.Threading)
Expand Down
4 changes: 3 additions & 1 deletion ReSharper.FSharp/test/data/features/completion/filtered/Expr - Base 01.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3863
Count: 3864
Focus: Soft
Range: "♦"

Expand Down Expand Up @@ -233,6 +233,7 @@ voption
#nowarn
#r
#time
#warnon
FSharpFunc
Failure exn
abs ^T
Expand Down Expand Up @@ -3887,6 +3888,7 @@ second |(in Microsoft.FSharp.Data.UnitSystems.SI.UnitNames)
#nowarn
#r
#time
#warnon
AbstractClassAttribute
AllowNullLiteralAttribute
Array
Expand Down
4 changes: 3 additions & 1 deletion ReSharper.FSharp/test/data/features/completion/filtered/Expr - Base 02 - Local.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3864
Count: 3865
Focus: Soft
Range: "♦"

Expand Down Expand Up @@ -234,6 +234,7 @@ voption
#nowarn
#r
#time
#warnon
FSharpFunc
Failure exn
abs ^T
Expand Down Expand Up @@ -3888,6 +3889,7 @@ second |(in Microsoft.FSharp.Data.UnitSystems.SI.UnitNames)
#nowarn
#r
#time
#warnon
AbstractClassAttribute
AllowNullLiteralAttribute
Array
Expand Down
4 changes: 3 additions & 1 deletion ReSharper.FSharp/test/data/features/completion/filtered/Expr - Module 01.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 326
Count: 327
Focus: Soft
Range: "♦"

Expand Down Expand Up @@ -235,6 +235,7 @@ voption
#nowarn
#r
#time
#warnon
FSharpFunc
Failure exn
abs ^T
Expand Down Expand Up @@ -348,6 +349,7 @@ using 'U
#nowarn
#r
#time
#warnon
AbstractClassAttribute
AllowNullLiteralAttribute
Array
Expand Down
4 changes: 3 additions & 1 deletion ...er.FSharp/test/data/features/completion/filtered/Expr - Record - Field - Empty 01.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3870
Count: 3871
Focus: Soft
Range: "let r: R1 = { ♦ }"

Expand Down Expand Up @@ -240,6 +240,7 @@ voption
#nowarn
#r
#time
#warnon
FSharpFunc
Failure exn
abs ^T
Expand Down Expand Up @@ -3899,6 +3900,7 @@ F3 int
#nowarn
#r
#time
#warnon
AbstractClassAttribute
AllowNullLiteralAttribute
Array
Expand Down
4 changes: 3 additions & 1 deletion ...er.FSharp/test/data/features/completion/filtered/Expr - Record - Field - Empty 02.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3876
Count: 3877
Focus: Soft
Range: "f { ♦ }"

Expand Down Expand Up @@ -246,6 +246,7 @@ voption
#nowarn
#r
#time
#warnon
FSharpFunc
Failure exn
abs ^T
Expand Down Expand Up @@ -3905,6 +3906,7 @@ F3 int
#nowarn
#r
#time
#warnon
AbstractClassAttribute
AllowNullLiteralAttribute
Array
Expand Down
4 changes: 3 additions & 1 deletion ...er.FSharp/test/data/features/completion/filtered/Expr - Record - Field - Empty 03.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3869
Count: 3870
Focus: Soft
Range: "if true then { F1 = 1 } else { ♦ }"

Expand Down Expand Up @@ -240,6 +240,7 @@ voption
#nowarn
#r
#time
#warnon
FSharpFunc
Failure exn
abs ^T
Expand Down Expand Up @@ -3898,6 +3899,7 @@ F3 int
#nowarn
#r
#time
#warnon
AbstractClassAttribute
AllowNullLiteralAttribute
Array
Expand Down
4 changes: 3 additions & 1 deletion ...er.FSharp/test/data/features/completion/filtered/Expr - Record - Field - Empty 04.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3870
Count: 3871
Focus: Soft
Range: "{ R = { ♦ } }"

Expand Down Expand Up @@ -241,6 +241,7 @@ voption
#nowarn
#r
#time
#warnon
FSharpFunc
Failure exn
abs ^T
Expand Down Expand Up @@ -3899,6 +3900,7 @@ F3 int
#nowarn
#r
#time
#warnon
AbstractClassAttribute
AllowNullLiteralAttribute
Array
Expand Down
4 changes: 3 additions & 1 deletion ...t/data/features/completion/filtered/Expr - Record - Field - Empty 05 - Another ns.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3874
Count: 3875
Focus: Soft
Range: "f { ♦ }"

Expand Down Expand Up @@ -243,6 +243,7 @@ voption
#nowarn
#r
#time
#warnon
FSharpFunc
Failure exn
abs ^T
Expand Down Expand Up @@ -3901,6 +3902,7 @@ Field int <==
#nowarn
#r
#time
#warnon
AbstractClassAttribute
AllowNullLiteralAttribute
Array
Expand Down
4 changes: 3 additions & 1 deletion ...er.FSharp/test/data/features/completion/filtered/Expr - Record - Field - Empty 06.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3869
Count: 3870
Focus: Soft
Range: "{ ♦ }"

Expand Down Expand Up @@ -233,6 +233,7 @@ voption
#nowarn
#r
#time
#warnon
F1 int
F2 int
F3 int
Expand Down Expand Up @@ -3892,6 +3893,7 @@ second |(in Microsoft.FSharp.Data.UnitSystems.SI.UnitNames)
#nowarn
#r
#time
#warnon
AbstractClassAttribute
AllowNullLiteralAttribute
Array
Expand Down
4 changes: 3 additions & 1 deletion ReSharper.FSharp/test/data/features/completion/filtered/Expr - Record - Field 01.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3656
Count: 3657
Focus: Soft
Range: "♦ }"

Expand Down Expand Up @@ -127,6 +127,7 @@ WebExtensions
#nowarn
#r
#time
#warnon
[FromSingleCompletion^, TypesAndNamespaces, NotImportedType, NormalSelectionPriority^, FromFullEvaluation, Other^]
ADVF |(in System.Runtime.InteropServices.ComTypes)
ASCIIEncoding |(in System.Text)
Expand Down Expand Up @@ -3683,6 +3684,7 @@ F3 int
#nowarn
#r
#time
#warnon
Array
Array2D
Array3D
Expand Down
4 changes: 3 additions & 1 deletion ...harp/test/data/features/completion/filtered/Expr - Record - Field 02 - Other type.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3656
Count: 3657
Focus: Soft
Range: "♦ }"

Expand Down Expand Up @@ -127,6 +127,7 @@ WebExtensions
#nowarn
#r
#time
#warnon
[FromSingleCompletion^, TypesAndNamespaces, NotImportedType, NormalSelectionPriority^, FromFullEvaluation, Other^]
ADVF |(in System.Runtime.InteropServices.ComTypes)
ASCIIEncoding |(in System.Text)
Expand Down Expand Up @@ -3682,6 +3683,7 @@ F4 int <==
#nowarn
#r
#time
#warnon
Array
Array2D
Array3D
Expand Down
4 changes: 3 additions & 1 deletion ReSharper.FSharp/test/data/features/completion/filtered/Expr - Record - Field 04.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3607
Count: 3608
Focus: Soft
Range: "♦ }"

Expand Down Expand Up @@ -76,6 +76,7 @@ yield
#nowarn
#r
#time
#warnon
[FromSingleCompletion^, TypesAndNamespaces, NotImportedType, NormalSelectionPriority^, FromFullEvaluation, Other^]
ADVF |(in System.Runtime.InteropServices.ComTypes)
ASCIIEncoding |(in System.Text)
Expand Down Expand Up @@ -3633,6 +3634,7 @@ F3 int
#nowarn
#r
#time
#warnon
abstract
and
as
Expand Down
4 changes: 3 additions & 1 deletion ReSharper.FSharp/test/data/features/completion/filtered/Expr - Record - Field 05.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3655
Count: 3656
Focus: Soft
Range: "♦ }"

Expand Down Expand Up @@ -126,6 +126,7 @@ WebExtensions
#nowarn
#r
#time
#warnon
[FromSingleCompletion^, TypesAndNamespaces, NotImportedType, NormalSelectionPriority^, FromFullEvaluation, Other^]
ADVF |(in System.Runtime.InteropServices.ComTypes)
ASCIIEncoding |(in System.Text)
Expand Down Expand Up @@ -3681,6 +3682,7 @@ F2 int <==
#nowarn
#r
#time
#warnon
Array
Array2D
Array3D
Expand Down
4 changes: 3 additions & 1 deletion ReSharper.FSharp/test/data/features/completion/filtered/Expr - Record - Field 06.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3653
Count: 3654
Focus: Soft
Range: "♦"

Expand Down Expand Up @@ -124,6 +124,7 @@ WebExtensions
#nowarn
#r
#time
#warnon
[FromSingleCompletion^, TypesAndNamespaces, NotImportedType, NormalSelectionPriority^, FromFullEvaluation, Other^]
ADVF |(in System.Runtime.InteropServices.ComTypes)
ASCIIEncoding |(in System.Text)
Expand Down Expand Up @@ -3679,6 +3680,7 @@ SecondProp string <==
#nowarn
#r
#time
#warnon
Array
Array2D
Array3D
Expand Down
4 changes: 3 additions & 1 deletion ...er.FSharp/test/data/features/completion/filtered/To recursive - Active pattern 01.fs.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Completion: Basic
Count: 3863
Count: 3864
Focus: Soft
Range: "♦"

Expand Down Expand Up @@ -232,6 +232,7 @@ voption
#nowarn
#r
#time
#warnon
FSharpFunc
Failure exn
abs ^T
Expand Down Expand Up @@ -3886,6 +3887,7 @@ second |(in Microsoft.FSharp.Data.UnitSystems.SI.UnitNames)
#nowarn
#r
#time
#warnon
A
AbstractClassAttribute
AllowNullLiteralAttribute
Expand Down
Loading
Loading