Feature: Improve sequence and combo hotkey support#1288
Open
Wxh16144 wants to merge 8 commits intoJohannesKlauss:mainfrom
Open
Feature: Improve sequence and combo hotkey support#1288Wxh16144 wants to merge 8 commits intoJohannesKlauss:mainfrom
Wxh16144 wants to merge 8 commits intoJohannesKlauss:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
…nce handling in useHotkeys
Wxh16144
force-pushed
the
wuxh/try-fix-array-sequentially
branch
from
ddad9a6 to
a4a1f9a
Compare
…otkeys separately
Wxh16144
force-pushed
the
wuxh/try-fix-array-sequentially
branch
from
461591d to
f746d7d
Compare
|
@JohannesKlauss Please let me know if you need any help with reviewing and testing this. |
pksunkara
approved these changes
Feb 9, 2026
pksunkara
left a comment
pksunkara
left a comment
There was a problem hiding this comment.
Looks great! I have manually tested these changes too and everything is working.
Would love to get this PR merged since it fixes important bugs with sequential hotkeys.
|
@Wxh16144 Can you please rebase this? |
pksunkara
reviewed
Feb 9, 2026
| : mapCode(e.code) | ||
|
|
||
| recordedKeys = [] | ||
| if (!isHotkeyModifier(currentKey.toLowerCase())) { |
There was a problem hiding this comment.
Need to keep the TODO comment about making modifiers work with sequences.
// TODO: Make modifiers work with sequences
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
["h>i", "o>k"])would not work as expected.