Add response headers to presigned URL v4#277
Open
mortenpi wants to merge 2 commits intoJuliaCloud:masterfrom
Open
Add response headers to presigned URL v4#277mortenpi wants to merge 2 commits intoJuliaCloud:masterfrom
mortenpi wants to merge 2 commits intoJuliaCloud:masterfrom
Conversation
Author
|
Just a friendly bump -- it would still be nice to get this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for
response-*query parameters for overriding response headers in v4 presigned URLs.Right now, you can pass
content_typetos3_sign_url, but it only does something for v2, and in v4 it is ignored. So here I am addingContent-Type+ all the other supported ones, but only tov4(as thev2version seems to be deprecated).It was a bit of a trial and error to figure out how exactly they should be incorporated into the signing process, but it seems to work:
leads to the following response when
GETed:If this broadly looks reasonable, them I'm happy to add some docs and tests as well.